akveo / akveo/nebular

Calendar I18n: some parts of the calendar can't be internationalized

未关闭
#1,111 0 条评论 5 个 reaction 已指派 0 人 在 GitHub 查看
enhancement module:components P2: important quality
主要语言
TypeScript
星标
8.1k
派生
1.5k
PR 合并指标
30 天内没有已合并 PR

描述

Some parts of the calendar kit can't be internationalized:

- [Here](https://github.com/akveo/nebular/blob/master/src/framework/theme/components/calendar-kit/components/calendar-header/calendar-header.component.ts#L21) we have `Today` word hardcoded in the template.
- Usage of Angular `DatePipe` [here](https://github.com/akveo/nebular/blob/master/src/framework/theme/components/calendar-kit/components/calendar-header/calendar-header.component.ts#L18) and [here](https://github.com/akveo/nebular/blob/master/src/framework/theme/components/calendar-kit/components/calendar-navigation/calendar-navigation.component.ts#L24) require Angular locale to be loaded, but can't be resolved another way, for example, when we're using another i18n library, which is not in Angular core.
- `getDate()` functionality is used in computations inside `calendar-kit`, also as exported for public use and may be overridden to provided proper i18n and this override may lead to errors.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。