akiran / akiran/react-slick

Next Page isn't calculated properly between responsive breakpoints

未关闭
#1,892 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
11.9k
派生
2.1k
PR 合并指标
30 天内没有已合并 PR

描述

Hello, I'm running into an issue when you have enough slides for more than 2 pages, the `nextPage` parameter in `beforeChange` isn't calculated properly for responsive carousels with varying rows (ex. `row: 1` vs `row: 4`).

Whenever you're on a page that's not the first or last page of the carousel and adjust the window size to trigger the responsive breakpoint, it defaults to the last page. Can try adding more slides in the example below to verify, the same issue still occurs.

This is the replicated example here: [CodeSandBox](https://codesandbox.io/s/react-slick-playground-forked-mq20b?file=/index.js)

From the replicated example above, I was expecting that if I was on page 2 (middle page) before the breakpoint trigger, after the breakpoint, `nextPage` in `beforeChange` would be 1 instead of 2.

`nextPage` before breakpoint

![image](https://user-images.githubusercontent.com/32151304/93259387-c95c8080-f76d-11ea-919b-814c5cc8e61e.png)

`nextPage` after breakpoint

![image](https://user-images.githubusercontent.com/32151304/93259508-f446d480-f76d-11ea-9f66-ebe3fd1906b0.png)
)

Wondering if this is the expected behaviour or not.

Any possible fix or work around would be great, thanks!

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。