akiran / akiran/react-highlight

Add support for React server components

Ouverte
#89 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
761
Forks
82
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

Using the Highlight component inside a component that is not marked with "use client" will throw the following error:

```
TypeError: Super expression must either be null or a function, not undefined
at _inherits (webpack-internal:///(rsc)/./node_modules/react-highlight/lib/index.js:43:15)
at eval (webpack-internal:///(rsc)/./node_modules/react-highlight/lib/index.js:56:5)
at eval (webpack-internal:///(rsc)/./node_modules/react-highlight/lib/index.js:120:2)
at (rsc)/./node_modules/react-highlight/lib/index.js (D:\XXX\.next\server\vendor-chunks\react-highlight.js:50:1)
```

This is happening because the `Highlight` component uses the lifecycle events `componentDidMount` and `componentDidUpdate`, which can't be used in RSC.

It would be interesting to add basic support for RSC, for example by providing a fallback component that just renders a `pre` element with no highlighting. Otherwise, users using this library and RSC will encounter this error which can be hard to debug.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.