akiran / akiran/react-highlight

Add support for React server components

Open
#89 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
761
Forks
82
PR merge metrics
No merged PRs in 30d

Description

Using the Highlight component inside a component that is not marked with "use client" will throw the following error:

```
TypeError: Super expression must either be null or a function, not undefined
at _inherits (webpack-internal:///(rsc)/./node_modules/react-highlight/lib/index.js:43:15)
at eval (webpack-internal:///(rsc)/./node_modules/react-highlight/lib/index.js:56:5)
at eval (webpack-internal:///(rsc)/./node_modules/react-highlight/lib/index.js:120:2)
at (rsc)/./node_modules/react-highlight/lib/index.js (D:\XXX\.next\server\vendor-chunks\react-highlight.js:50:1)
```

This is happening because the `Highlight` component uses the lifecycle events `componentDidMount` and `componentDidUpdate`, which can't be used in RSC.

It would be interesting to add basic support for RSC, for example by providing a fallback component that just renders a `pre` element with no highlighting. Otherwise, users using this library and RSC will encounter this error which can be hard to debug.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.