akiran / akiran/react-foundation-apps

The modal's overlay allows closing without an event

Abierto
#34 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
291
Forks
45
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Their is no way to detect when a user clicks away from the model (on the background) triggering it to close. The event happens here when it calls `this.setState({open: false})`:

https://github.com/akiran/react-foundation-apps/blob/master/src/modal/index.jsx#L35

``` javascript
hideOverlay: function (e) {
e.preventDefault();
if (this.props.overlayClose) {
this.setState({open: false});
}
},
```

In our case, we can't use `componentWillUnmount`, we are using a global model that remains mounted the entire life of the app. When subscribed to the model `ZfApi.subscribe(this.props.modalId, (name, msg) => {` it would be ideal to see a "close" event issued for the `overlayClose` in addition to the `X` and `Cancel`.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.