akinsho / akinsho/toggleterm.nvim

[BUG] toggleterm changing terminal width strangely with `signcolumn = "yes"`

Open
#582 0 comments 4 reactions 0 assignees View on GitHub
Dominant language
Lua
Stars
5.6k
Forks
206
PR merge metrics
No merged PRs in 30d

Description

### Is there an existing issue for this?

- [X] I have searched the existing issues

### Current Behavior

When setting `hide_numbers = true` and have `vim.opt.signcolumn = "yes"`, open some full screen app, it renders beyond the screen, e.g. lazygit
![image](https://github.com/akinsho/toggleterm.nvim/assets/30885216/f46464bf-7ba1-46f2-8800-64a2dd605359)
and if I press tab to switch to next lazygit window, It will looks like:
![image](https://github.com/akinsho/toggleterm.nvim/assets/30885216/f1abb72d-05db-4e39-960f-f567b019e6f7)
this happened after I upgrade to nvim 0.10, now I'm setting hide_numbers to false, and add a on_open hook to achieve the same behavior and it work well:
```
on_open = function()
local ol = vim.opt_local
ol.number = false
ol.signcolumn = "no"
ol.relativenumber = false
end,
```

### Expected Behavior

Work like normal terminal

### Steps To Reproduce

1. Toggleterm with direction horizontal, not sure if other direction have the same issue
2. Have `vim.opt.signcolumn = "yes"`
3. Open toggleterm and run lazygit in terminal

### Environment

```Markdown
- OS: NixOS 23.11
- neovim version: 0.10
- Shell: zsh
```

### Anything else?

_No response_

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.