akanshSirohi / akanshSirohi/ShareX

Escape quotes in filenames

Abierto
#88 1 comentario 0 reacciones 0 asignados Ver en GitHub
bug
Lenguaje dominante
Java
Estrellas
295
Forks
20
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

**Describe the bug**
Can't download any files with a single quote in the name. For example, the following error when trying to download this file:

`near "s": syntax error (code 1 SQLITE_ERROR): , while compiling: SELECT ID FROM T_HIST WHERE PATH='/storage/emulated/0/Books/Android's Dream, The - John Scalzi.epub'`

Clearly this is a problem, as files can have single quotes in their names. It also concerns me that there is a huge potential for SQL overflow bugs here, as filenames are obviously not being properly escaped...

**Steps To Reproduce**
Steps to reproduce the behavior:
1. Select a file with a single quote in the name `'`.
2. Try to download from the menu.

**Device Details (please complete the following information):**
- Version: Android 11
- Device: Moaan InkPlus

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.