akalongman / akalongman/php-string-compare

function parameter is ignored when set to false

未關閉
#1 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
PHP
星號
14
分支
4
PR 合併指標
30 天內沒有已合併 PR

描述

Thanks for the script.

I added a functionality to do a compare case insensitive by adding an additional parameter 'ignore_case'.

    $phpStringCompare = new StringCompare($string1, $string2,

array('remove_html_tags'=>true, 'remove_extra_spaces'=>true, 'ignore_case'=>true,
'remove_punctuation'=>true, 'punctuation_symbols'=>Array('.', ','))
);

I found that when I set the 'ignore_case' parameter to true the script functions as normal. When I set the 'ignore_case' to false then too the script does a case insensitive comparison.
By modifying the lines from

        if (!empty($params['ignore_case'])) {

$this->_ignore_case = $params['ignore_case'];
}

to

        if (isset($params['ignore_case'])) {

$this->_ignore_case = $params['ignore_case'];
}

the script works as expected. This I guess is because of !empty check. false value returns empty using the check and hence skips the steps. Please correct me if I'm missing something.
Thanks,
Pari

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。