ajwheeler / ajwheeler/Korg.jl

Korg vs MARCS electron number density tracking issue

Open
#182 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
Julia
Stars
67
Forks
15
Avg merge
2d 6h
Merged PRs (30d)
6

Description

**edit: newer plots are below this post**
---
#179 modifies Korg to recalculated the electron number density, rather than taking the value from the model atmosphere at face value.

In general, things look pretty good at the photosphere. "reldiff" here is `(recalculated ne/marcs ne) - 1`. The dissagreement at low logg/high Teff is no big deal since that part of the Kiel diagram is unphysical. Those marcs atmospheres didn't converge and were filled in with RBF extrapolation, so the thing I'm comparing to probably isn't physically self-consistent. For the M dwarfs, I think the problem is the lack of charged molecules, but I'm not certain.
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/bfbc24b1-3c1c-4ece-ab21-8a6972d330d9)

If you look at the worst case atmospheric layer, the match is much worse. Again the worst stuff is happening in the part of the Kiel diagram without many stars (low logg/high Teff). In this regime, the worst disagreement is at the bottom of the atmosphere. It's notable that `calculated ne/marcs ne` is very close to 1, but I haven't been able to come up with a theory of what's going on.
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/8d18ec1f-738a-4ef5-b98a-9f4c28a1f97a)
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/9306d3a1-25ea-412d-806c-9d9b6f1b0e25)

Here's the electron number densities in the lowest layer of the atmosphere calculated by Korg (first) and MARCS (second). The Korg electron number densities have "structure" not found in the marcs values which corresponds to a sharp increase in the temperature at tau=100 (plotted third). This seems likely to be driven by the model atmosphere interpolation.
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/404e0c1e-8bab-481b-a388-c112a77283c2)
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/09aae550-e345-468e-9ed9-c7abe819503b)
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/0ab5cc82-e16d-47ff-8e2c-3df240bd0495)

One last plot: This is `(recalculated ne/marcs ne) - 1` as a function of $\tau$ across the Kiel diagram. The gray lines show the "zero" for each tiny plot, and the red dot marks the photosphere.
![image](https://github.com/ajwheeler/Korg.jl/assets/711963/92e29571-9bd7-4f51-bfdb-7da08e1087da)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.