ajwheeler / ajwheeler/Korg.jl

isotopic abundance corrections mess up default radiative gamma recipe

未关闭
#174 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
Julia
星标
67
派生
15
平均合并
2 天 6 小时
30 天内合并 PR
6

描述

When the radiative broadening factor is not available, it is estimated from the wavelength and `log_gf` value. That `log_gf` value will be wrong if it was adjusted for isotopic abundances.

#173 addresses this for turbospectrum and VALD linelists in the case that Korg does the adjustment itself, but in cases where VALD has already done the adjustment, it's not obvious what should be done.

options:
- Nothing, just add a warning to the documentation. (I don't like this one.)
- Refuse to parse. This is easy and prevents things from going wrong, but it would likely annoy people.
- Try to do things correctly. We could in principle undo the adjustment if we knew what VALD assumed, and it will work as long as they never change it. This is the most seemless, but it's also brittle.

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。