ajacksified / ajacksified/Mediator.js

Difference in removing all / single subscriber

Ouverte
#30 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
460
Forks
75
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I was looking at the `removeSubscriber` method of the `Channel` object and I noticed something that I can't explain.

When removing a specific subscriber you set the `channel` property of the subscriber to `null` before removing it from the array of subscribers. When all the subscribers get cleared due to the `id` param being `null` the array is simply cleared and the `channel` property on all the subscribers don't get reset to `null`.

Is there a specific reason for this or is it an oversight?

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.