ajacksified / ajacksified/Mediator.js

Difference in removing all / single subscriber

Abierto
#30 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
460
Forks
75
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

I was looking at the `removeSubscriber` method of the `Channel` object and I noticed something that I can't explain.

When removing a specific subscriber you set the `channel` property of the subscriber to `null` before removing it from the array of subscribers. When all the subscribers get cleared due to the `id` param being `null` the array is simply cleared and the `channel` property on all the subscribers don't get reset to `null`.

Is there a specific reason for this or is it an oversight?

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.