Optional traffic policy fields and annotation parity for chart v2 Services
- Linguagem predominante
- Python
- Estrelas
- 22.1k
- Forks
- 5.4k
- Merge médio
- 5h
- PRs com merge (30d)
- 671
Descrição
The airbyte-platform PR template directs contributions here, so filing this as an issue with a ready patch.
## Proposed change
Adds optional, values-driven fields to every Service template in charts/v2/airbyte:
* `internalTrafficPolicy` (Cluster or Local)
* `externalTrafficPolicy` (rendered only for NodePort or LoadBalancer Services, as the API requires)
* `trafficDistribution` (for example `PreferClose`, Kubernetes 1.30+)
* optional `appProtocol` on port entries
* an `annotations` block for the two Services that currently lack one (temporal, stigg-sidecar), bringing them to parity with the other seven
All fields are optional and gated with `with`/`if`. A chart rendered without them is byte-identical to today.
## Why
Self-managed deployments on multi-AZ clusters want zone-aware routing for in-cluster traffic to Airbyte's Services to reduce cross-AZ latency and data transfer cost. These are standard Kubernetes Service fields, but none of the nine Service templates currently accept them, so the only option is patching Services after `helm upgrade`, which leaves cluster state unmanaged by the chart.
## How
Follows the chart's existing conventions: guarded blocks in the templates, `# --` helm-docs annotations for every new key in values.yaml, defaults empty. No changes to autogenerated files under templates/config.
A ready patch is available at https://github.com/airbytehq/airbyte-platform/compare/main...RafPe:airbyte-platform:chart-service-field-passthroughs; happy to open it as a PR wherever you prefer.
---
**Internal Tracking:** https://github.com/airbytehq/oncall/issues/13247
Guia de contribuição
Direção de pesquisa
Start with the Service templates under charts/v2/airbyte and values.yaml. Compare their existing guarded conventions and helm-docs annotations, then render the chart with defaults and configured traffic-policy, appProtocol, and annotation values. Done means default output remains byte-identical and the optional fields render only where specified.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- helm, kubernetes
- Domínio
- devops, infrastructure
- Tipo de issue
- Funcionalidade
- Dificuldade
- 3/5
- Tempo estimado
- 1-2 dias
- Status de atividade
- Pouca atividade
- Clareza
- Claramente especificada
- Facilidade para iniciantes
- 55/100