airbytehq / airbytehq/airbyte-python-cdk

[SelectiveAuthenticator] TypeError when attempting to create SessionTokenAuthenticator

Open
#422 2 comments 2 reactions 0 assignees View on GitHub
community
Dominant language
Python
Stars
26
Forks
53
Avg merge
2d 6h
Merged PRs (30d)
10

Description

## Component

SelectiveAuthenticator Component Factory

## Description

Attempting to create a SelectiveAuthenticator which includes a SessionTokenAuthenticator currently fails with `TypeError: ModelToComponentFactory.create_session_token_authenticator() missing 1 required positional argument: "'name' ","failure_type":"system_error"`

This is because [`create_selective_authenticator`](https://github.com/airbytehq/airbyte-python-cdk/blob/7a8cb929139443e392554d94567ad4824092257e/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py#L2659-L2662) does not pass kwargs to the `ModelToComponentFactory._create_component_from_model`when creating authenticators for the SelectiveAuthenticator. kwargs contains the name argument passed down from `create_declarative_stream`which is required in [`create_session_token_authenticator`](https://github.com/airbytehq/airbyte-python-cdk/blob/7a8cb929139443e392554d94567ad4824092257e/airbyte_cdk/sources/declarative/parsers/model_to_component_factory.py#L856-L857)

## Proposed solution
Pass kwargs to `_create_component_from_model` when creating authenticators for SelectiveAuthenticator

✅ Yes, I want to contribute

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.