airbytehq / airbytehq/airbyte-python-cdk

Evaluate performance impact of `deprecated` decorator in hot codepath

未關閉
#116 3 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Python
星號
26
分支
53
平均合併
2 天 6 小時
30 天內合併 PR
10

描述

There is one `deprecated` decorator in the hot code path which was initially moved to the class level to reduce performance impact, and which I've moved back to the method level but _commented-out_ to avoid any performance impact. Since migrating from the `Deprecated` third party library to the [PEP 702](https://peps.python.org/pep-0702/#backwards-compatibility) native support for `@deprecated` decorators, we might be in a better situation now with performance, but I didn't want to take a risk. I also didn't want to trigger a deprecated warning on the whole class if only one method is deprecated.

https://github.com/airbytehq/airbyte-python-cdk/blob/bd2e5affd196b2f36dfc0fb8bbbae07771dde188/airbyte_cdk/sources/streams/core.py#L434-L444

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。