airbytehq / airbytehq/airbyte-api-python-sdk

Speakeasy generator bug: missing model_rebuild() for models with circular TYPE_CHECKING imports

Ouverte
#186 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
61
Forks
27
Merge moyen
4 min
PR mergées (30 j)
2

Description

## Problem

Speakeasy's Python generator uses `TYPE_CHECKING` imports to break circular schema references, but only emits `model_rebuild()` for the immediate forward-referenced model — not for models that transitively depend on it. This causes `PydanticUserError: not fully defined` at instantiation time for any model in the dependency chain.

## Affected Schema

`RowFilteringOperationNot` has a recursive `conditions` field:

```yaml
RowFilteringOperationNot:
properties:
conditions:
type: array
items:
$ref: "#/components/schemas/RowFilteringOperation" # circular
RowFilteringOperation:
oneOf:
- $ref: "#/components/schemas/RowFilteringOperationEqual"
- $ref: "#/components/schemas/RowFilteringOperationNot" # back-reference
```

The upstream spec marks this: `x-airbyte-circular-ref: true`.

## Symptoms

Speakeasy generates `RowFilteringOperationNot1` (with `1` suffix from name collision) and imports `RowFilteringOperation` under `TYPE_CHECKING`. It emits `RowFilteringOperationNot1.model_rebuild()` in `__init__.py` but NOT for dependent models. Result:

```
PydanticUserError: \`ConnectionResponse\` is not fully defined;
you should define \`RowFilteringOperationNot1\`, then call \`ConnectionResponse.model_rebuild()\`.
```

3 models affected: `ConnectionsResponse`, `RowFilteringMapperConfiguration`, `StreamConfigurations`.

## Workaround

We use an OpenAPI overlay to break the circular `$ref` by pointing `RowFilteringOperationNot.conditions.items` directly at `RowFilteringOperationEqual` instead of `RowFilteringOperation`:

```yaml
# overlays/python_speakeasy.yaml
actions:
- target: "$.components.schemas.RowFilteringOperationNot.properties.conditions.items"
update:
$ref: "#/components/schemas/RowFilteringOperationEqual"
```

This removes the recursion (`NOT(NOT(x)) = x`, so nested NOT is redundant) and allows Speakeasy to generate clean direct imports without `TYPE_CHECKING`.

## Investigation

- All Speakeasy fix flags were tested individually and in combination (PRs #180-#183) — none fixed this
- Overlay renames were tested (PR #184) — the `1` suffix and `TYPE_CHECKING` pattern are caused by the circular dependency, not the name collision
- The overlay flattening approach (PR #184 final iteration) works: all 738 model imports pass, all 4 previously broken models pass `model_json_schema()`

## Upstream Fix Needed

Speakeasy should emit `model_rebuild()` for ALL models that transitively depend on `TYPE_CHECKING` forward refs, not just the immediate one. This would fix the issue without needing the overlay workaround.

## Related

- #178 — original bug report for forward-reference errors in 1.0.0
- PR #179 — fixed NameError variant (enabled `nameResolutionFeb2025` + `conflictResistantModelImportsFeb2026`)
- PR #184 — overlay fix for the model_rebuild variant

---
[Devin session](https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888)

_Reported by @aaronsteers, investigated and documented in [Devin session](https://app.devin.ai/sessions/854c664803f3400387fdaa02e123b888)._

Guide de contribution

Ouvrir le guide de contribution

Piste de recherche

Inspectez les entrées __init__.py générées et les imports circulaires de TYPE_CHECKING pour RowFilteringOperationNot1, ConnectionsResponse, RowFilteringMapperConfiguration et StreamConfigurations. Reproduisez l’échec en instanciant les modèles concernés, puis exécutez model_json_schema() comme indiqué. C’est terminé lorsque les modèles dépendants transitivement gèrent les références anticipées sans dépendre de overlays/python_speakeasy.yaml.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Évaluation

Stack technique
openapi, python
Domaine
api
Type d'issue
Bug
Difficulté
4/5
Temps estimé
3-5 jours
Activité
Calme
Clarté
Plutôt claire
Accessibilité débutants
38/100

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.