airbytehq / airbytehq/PyAirbyte

Proposal: Use Docker Python SKD instead of CLI

オープン
#921 コメント 0 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
344
フォーク
77
平均マージ
1日 11時間
マージ済み PR(30日)
35

説明

Hello, I'd like to suggest replacing the `docker` CLI that's used by PyAirbyte with the [Python Docker SDK](https://docker-py.readthedocs.io/) and wanted to hear your opinion on that.

From what I see, `DockerExecutor` is the only place using it. The current implementation is rather minimal and reuses most of the process handling from the base Executor, but it requires a `docker` binary to be installed and available, and it pumps stdin from a subprocess call.

Instead, DockerExecutor could manage containers using the Python Docker SDK, which is a lightweight Python library and requires only the Docker socket to work.

I don't have anything concrete yet. I'm just looking around for options to reduce the size of dependencies, and the requirement for the `docker` binary may not be necessary. But I can handle the implementation of it.

Do you have any thoughts on this?

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。