airbytehq / airbytehq/PyAirbyte

VenvExecutor fails to install a connector package if it has the wrong executable name

未关闭
#290 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看
bug good first issue
主要语言
Python
星标
344
派生
77
平均合并
1 天 11 小时
30 天内合并 PR
35

描述

## Problem

In https://github.com/airbytehq/airbyte/pull/40693, we've been fixing source-braintree, and mistakenly set it's script name wrong:

```
[tool.poetry.scripts]
source-braintree = "source_braintree.run:run"
```

When pyairbyte tried to validate, it rightfully noticed that `source-braintree` is not a valid executable in the venv, and attempted reinstalling, but:

```
Successfully built source-braintree

...

Thank you for using PyAirbyte!
Anonymous usage reporting is currently enabled. For more information, please see https://docs.airbyte.com/telemetry
Creating source and validating spec is returned successfully...
Connector executable not found within the virtual environment at
/airbyte-integrations/connectors/source-braintree/.venv-source-braintree/bin/sou
rce-braintree.
Reinstalling...
Installing 'source-braintree' into virtual environment
'/airbyte-integrations/connectors/source-braintree/.venv-source-braintree'.
Running 'pip install airbyte-{connector_name}'...
```

So what happens here is that `self.pip_url` of the executor silently becomes `connector_name`. I see it defaults to `self.name`, but don't see the problem deeper. A nice puzzle if someone wants to tinker ;)

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。