aio-libs / aio-libs/sockjs

Access to query strings (GET params) in user-defined endpoint handlers

オープン
#37 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Python
スター
117
フォーク
39
PR マージ指標
30日以内にマージされた PR はありません

説明

[SockJS (the client side) allows adding query strings to the endpoint URL.](https://github.com/sockjs/sockjs-client/issues/72)
Here, currently there is no way to access them (e.g., `request.GET`) inside user-defined endpoint handler coroutines. I'd like to access them! :eyes:

In the code, sockjs seems to invoke the user-defined endpoint handler in `SessionManager.acquire()` and `_acquire()` methods, which is called by transports' `process()` coroutines. `SockJSRoute` and transport subclasses have access to the aiohttp's request object but it is not passed to the user-defined handler via `acquire` method chains.

Maybe it is not a good idea to pass the whole request object to user-defined handlers due to design principles such as "separation of concern", but still I think it would be nice to have access to GET parameters.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。