aio-libs / aio-libs/aiohttp

Force-closing of proxy connections is broken

Ouverte
#4,953 0 commentaires 1 réaction 0 personnes assignées Voir sur GitHub
bug
Langage dominant
Python
Étoiles
16.5k
Forks
2.4k
Merge moyen
17 h 22 min
PR mergées (30 j)
212

Description

🐞 **Describe the bug**

#3070 introduced force-closing of proxy connections, though the way it has been implemented (`proto.force_close()` call) doesn't work. So instead of making such hard-coded things I suggest removing this code and instead adding into documentation something like this: "If you're experiencing timeouts or other issues with proxy connections, use `force_close=True` to force close proxy connections after each request/response".

💡 **To Reproduce**

1. Spin up proxy
2. Set up Connector with high `keepalive_temeout`
2. Run `session.get()` call in while-loop with `asyncio.sleep()`
3. `watch -n 0.5 'netstat -napt |grep 8888'` where 8888 is your proxy port
4. See proxy connections not being closed

💡 **Expected behavior**

1. No confusing broken code in the library
2. Let the user decide to close or not proxy connections (just use `force_close`)

📋 **Your version of the aiohttp/yarl/multidict distributions**

```console
$ python -m pip show aiohttp
Name: aiohttp
Version: 3.6.1
...
```

📋 **Additional context**

client

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.