aio-libs / aio-libs/aiohttp

Can't specify both fingerprint and SSLContext for client request

Open
#3,679 7 comments 0 reactions 2 assignees Claimed by @webknjaz View on GitHub
bug client question
Dominant language
Python
Stars
16.5k
Forks
2.4k
Avg merge
17h 22m
Merged PRs (30d)
212

Description

## Long story short

It appears that 4.0 will remove all the SSL parameters from the `TCPConnector` class except for a single `ssl` parameter (#2626). This appears to be quite limiting: for example, it would no longer be possible to supply a client certificate and simultaneously pin the expected server certificate. The former requires you to pass the `SSLContext` configured with the client certificate as the `ssl` parameter, but for the latter you would have to pass a `Fingerprint`. Is there a recommendation for how this could be achieved?

## Expected behaviour

Should be possible to make a request with BOTH a client certificate and a pinned server certificate.

## Actual behaviour

It appears this will be removed with no alternative offered in 4.0.

## Steps to reproduce

N/A

## Your environment

client

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.