aio-libs / aio-libs/aiohttp

Redirect on ws_connect gives confusing result

未关闭
#3,678 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
Python
星标
16.5k
派生
2.4k
平均合并
17 小时 22 分钟
30 天内合并 PR
212

描述

## Long story short

I'm implementing a websocket service on existing HTTP server software. The server can be (and is by default) configured to redirect all HTTP traffic to HTTPS. The clients can choose to connect over HTTP or HTTPS. When connecting to `ws://service/ws` you will get a redirect to `https://service/ws` if the server is running with HTTP redirect to HTTPS.

Allowing `ws_connect(..., allow_redirects=False)` would at least allow me to detect this scenario without assuming that an HTTP 401 means "you got an HTTP Redirect, and followed it after dropping credentials."

## Expected behaviour

ws_connect('ws://service/ws', auth=auth) -> either a redirect related error or success

## Actual behaviour

The client gets HTTP 401, as credentials aren't included in the redirected request.

## Steps to reproduce

`ws_connect('ws://service/ws', auth=auth)` against a server that redirects HTTP traffic to HTTPS and requires basic auth.

## Your environment

Python 3.7.3rc1, aiohttp 3.5.1 (client)

Server is `nginx` with a `boost::beast` websocket service running behind a reverse proxy on `/ws`.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。