aio-libs / aio-libs/aiohttp-session

Documentation for `Session.created` does not match actual behavior

Open
#981 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
245
Forks
91
Avg merge
2m
Merged PRs (30d)
4

Description

The [documentation for `Session.created`](https://aiohttp-session.readthedocs.io/en/stable/reference.html#aiohttp_session.Session.created) states that this field represents "Creation UNIX TIMESTAMP, the value returned by `time.time()` for very first access to the session object."

This appears to be incorrect. In practice, `Session.created` seems to contain the timestamp of the last time the session data was changed. There is also some inconsistency to this. In particular, `Session.created` is only updated if you change the session by explicitly setting or deleting a value. Calling `Session.changed()` or `Session.invalidate()` does not update `Session.created`, even though these methods also change the session.

What is the intended behavior of `Session.created`? Please update the documentation and/or code so that the documented and actual behavior match.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.