aio-libs / aio-libs/aiohttp-session

Decoding data is not nesessary on some Redis configurations

Open
#294 15 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
245
Forks
91
Avg merge
2m
Merged PRs (30d)
4

Description

What reason for this line here?
https://github.com/aio-libs/aiohttp-session/blob/606cacafc47383f99cff39aba31f20bb5db3b879/aiohttp_session/redis_storage.py#L53

I want to store some bytes in session. Changed encoder ` setup_session(app, RedisStorage(redis_pool, encoder=pickle.dumps, decoder=pickle.loads))`. And I have error on getting session:
```

data = data.decode('utf-8')
UnicodeDecodeError: 'utf-8' codec can't decode byte 0x80 in position 0: invalid start byte

```
It also breakes `msgpack`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.