aio-libs / aio-libs/aiohttp-cors

403 Error when aiohttp resources are not fully merged

Aperta
#226 1 commento 4 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
220
Fork
61
Merge medio
2m
PR unite (30g)
3

Descrizione

Aiohttp merges resources, when they are added in the correct order:
![screenshot from 2019-02-22 15-40-04](https://user-images.githubusercontent.com/9722121/53249503-854fe980-36b8-11e9-9798-7862a9a283b3.png)

When using aiohttp-cors, resources have to be fully merged, or you end up having 2 resources for the same path, one for the GET method one for the POST, but the latter will not be considered when aiohttp-cors answers the OPTIONS request. It seems that aiohttp-cors supports only a single resource per path.

It would be nice if a hint about this could be added to the docs, if the support of multiple resources for the same path is too complex.

Requirements:
```
aiohttp==3.0.6
aiohttp_cors==0.7.0
```

Replicate:
```
def handler():
pass

app.router.add_route('POST', '/a', handler)
app.router.add_route('GET', '/b', handler)
app.router.add_route('PUT', '/a', handler)

# Configure default CORS settings.
cors = aiohttp_cors.setup(app, defaults={
"*": aiohttp_cors.ResourceOptions(
allow_credentials=True,
expose_headers="*",
allow_headers="*")
})

# Configure CORS on all routes.
for route in list(app.router.routes()):
cors.add(route)

```

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.