aiidalab / aiidalab/aiidalab-launch

Do we need to make the CLI more similar to docker command with combining the purposes?

Aperta
#192 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
7
Fork
4
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

In fact, I think the profile concept is not very useful to end user. If we regard `aiidalab-launch` as a wrapper of a combination of multiple docker commands, it maybe makes sense to have the CLI command match with the docker command which are:
- `docker run` -> `aiidalab-launch run`: to start from an image. (this will be the combination of current `aiidalab-launch profile add` + `aiidalab-launch profile start`)
- `docker stop` -> `aiidalab-launch stop`: stop the container, it is the same from what it is now.
- `docker rm` -> `aiidalab-launch rm`: remove the container (for aiidalab-launch case also remove the volume), this is then what I was going to achieve in this PR. It is the combination of the current `aiidalab-launch reset` and `aiidalab-launch profile remove`.

_Originally posted by @unkcpz in https://github.com/aiidalab/aiidalab-launch/pull/189#discussion_r1344661778_

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.