aiidalab / aiidalab/aiidalab-demo-server

Pin a specific version of the image

未關閉
#45 0 則留言 0 個 reaction 已指派 1 人 已被 @mikibonacci 認領 在 GitHub 檢視
主要語言
HTML
星號
3
分支
4
平均合併
28 分鐘
30 天內合併 PR
2

描述

We should pin a specific version for the AiiDAlab (or QE app) image we deploy on the demo server. As pointed out by @giovannipizzi, in this way we can safely deploy the latest image of the app without the risk of propagating potential issues in the server.

Now we do this:

```yaml
singleuser:
image:
name: aiidalab/qe
tag: latest
pullPolicy: Always
```

we should pin:

```yaml
singleuser:
image:
name: aiidalab/qe
tag: {{ environ('TAG') }}
pullPolicy: Always
```

also, maybe we can then put the `pullPolicy` to be `IfNotPresent` instead of `Always`, as maybe it can save startup time. We do not need to check the digest then (as now currently done using the `Always` policy), but only the tag name.

貢獻指南

這個儲存庫沒有索引到貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。