aidenybai / aidenybai/react-scan

It doesn't work in multi-window setup based on `window.open` and `createPortal`

Ouverte
#433 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
21.8k
Forks
390
Merge moyen
23 min
PR mergées (30 j)
1

Description

I want to add react-scan to Electron app that renders into multiple windows from the same JavaScript thread using `const newWindow = window.open` and then `createPortal(, newWindow)`.

In that case react-scan seems not to work at all

https://pietrasiak.com/creating-multi-window-electron-apps-using-react-portals#aad5d08cfa4d413a8ff6979ebe267fa3

I've wrote article on quirks of this setup

eg.
- `instanceof HTMLElement` will not work as it should be `instanceof ownerWindow.HTMLElement`
- highlights div cannot be created like `document.createElement(), document.body.appendChil` - needs `ownerWindow.documentElement`
- it essentially needs one highlighter per window in which react fiber renders

I understand it is quite major edge case, so not expecting it to be adjusted, just wanted to let you know

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.