agusmakmun / agusmakmun/django-markdown-editor

markdownfy_view is unauthenticated - Please consider changing it

Aperta
#194 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
901
Fork
1.3k
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Currently the installation document/README just says add URLs to your Django. No issues with this part. What is not specified here is that the URL `/martor/markdownify/` now becomes "public". By itself, it is not a problem. There maybe many "mitigating" circumstances such as ALBs that don't allow `/martor/` URLs and such. But, if someone were to just directly deploy this without reading the code, they have unintentionally exposed an _unauthenticated_ URL.

Either we should call it out explicitly in the README, or better yet, there should be no reason for the function `markdownfy_view` to not have the `login_required` decorator which all the other functions have.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.