agusmakmun / agusmakmun/django-markdown-editor

markdownfy_view is unauthenticated - Please consider changing it

Open
#194 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
901
Forks
1.3k
PR merge metrics
No merged PRs in 30d

Description

Currently the installation document/README just says add URLs to your Django. No issues with this part. What is not specified here is that the URL `/martor/markdownify/` now becomes "public". By itself, it is not a problem. There maybe many "mitigating" circumstances such as ALBs that don't allow `/martor/` URLs and such. But, if someone were to just directly deploy this without reading the code, they have unintentionally exposed an _unauthenticated_ URL.

Either we should call it out explicitly in the README, or better yet, there should be no reason for the function `markdownfy_view` to not have the `login_required` decorator which all the other functions have.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.