Restore Backup not working
- Lingua principale
- Kotlin
- Stelle
- 4.8k
- Fork
- 593
- Merge medio
- 1m
- PR unite (30g)
- 1
Descrizione
DBFlow Version: 4.2.4
Bug Request:
When database is corrupted in way that integrity check returns not ok restore db doesn't work.
Description:
In DatabaseHelperDelegate.restoreBackup there is a bug related to get proper file names. Instead of X.getDatabaseName() inside FlowManager.getContext().getDatabasePath() there should be X.getDatabaseFileName()
also, I think temp database name should contains the same extention and code needs changes:
public static String getTempDbFileName(DatabaseDefinition databaseDefinition) {
return TEMP_DB_NAME + databaseDefinition.getDatabaseName() + databaseDefinition.getDatabaseExtensionName();
}
and last thing. In restoreBackup system should close database before file copy. In other case after reopen there will be a problem with still opened corrupted db.
Kind regards, Krzysztof
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.