agronholm / agronholm/sqlacodegen

SQLModelGenerator does not respect table names

Ouverte
#208 1 commentaire 1 réaction 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
2.4k
Forks
284
Merge moyen
2 j 1 h
PR mergées (30 j)
1

Description

Love the addition of the SQLModelGenerator. However the generated models transform the table names in undesired ways (e.g. `some_random_table` becomes `somerandomtable`).

Removing `render_class_variables` from the SQLModelGenerator class, or simply calling `super().render_class_variables` there fixes the issue. `DeclarativeGenerator.render_class_variables` adds the `__tablename__` class variable, which is supported by SQLModel, see [here](https://github.com/tiangolo/sqlmodel/issues/159#issuecomment-978357069).

I'm happy to open a PR, but I'm not sure if this would have unintended consequences (or if there's a better way to accomplish this).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.