agoda-com / agoda-com/net-loadbalancing
Add resource parameter to `OnError` error handler
- Lenguaje dominante
- C#
- Estrellas
- 25
- Forks
- 16
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
# Feature request
## Type
- [ ] - Enhancement - completely new feature
- [x] - Improvement - make what we have better
## Is your feature request related to a problem?
Currently it is not possible to include information about the resource when logging errors in an `OnError` error handler of `ResourceManager.ExecuteAction`, because it only gets the `exception` and the `attemptCount`.
```c#
public delegate void OnError(Exception error, int attemptCount);
```
## Describe the solution you'd like
An extra `resource` parameter in `OnError`.
Example:
```c#
_resourceManager.ExecuteAction(
(serverOptions, _) => doSomething(serverOptions),
(attemptCount, _) => attemptCount <= 3,
(exception, attemptCount, serverOptions ) => _logger.LogError(
exception,
"Failed to connect to server {Host}:{Port}: {Message}",
serverOptions .Host, serverOptions .Port, exception.Message
)
);
```
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.