agoda-com / agoda-com/net-loadbalancing

Deploy pipeline failing on PRs opened from forks

Aperta
#37 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
C#
Stelle
25
Fork
16
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

# Bug report

## Describe the bug

The deploy pipeline is failing on PRs opened from forks, because it cannot access API key (secrets are not shared with forks).

Is there a way around it? Or alternatively should we remove this workflow from PRs and have it only on main branch? What's the use-case for publishing from PRs?

## To Reproduce

1. Fork this repo
2. Create a PR with any change
3. Wait for deploy pipeline results - for example: https://github.com/agoda-com/net-loadbalancing/actions/runs/3443243315/jobs/5745853755

## Expected behavior

Pipeline should be green.

## Screenshots

Pipeline is red.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.