agilgur5 / agilgur5/trim-canvas

Add optional arg to duplicate / clone canvas

Abierto
#6 0 comentarios 0 reacciones 0 asignados Ver en GitHub
feature
Lenguaje dominante
JavaScript
Estrellas
74
Forks
5
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

i.e. `trimCanvas(canvas, {duplicate: true})`.

Given the intense demand seen by the number of upvotes on https://github.com/szimek/signature_pad/issues/49#issuecomment-260976909 it seems like it should be included by default.

I'm also reading through my own docs for the first time in a while and if you don't know how canvas or cloning works, it may be quite unintuitive.

It's only a handful of lines of code, but IIRC the reason why I didn't include it (or removed it rather) was because it introduced a dependency on `canvas`, meaning it wouldn't work in Node (requires a pretty massive native dependency). If it's hidden behind an optional flag though, this shouldn't be problematic.
This is something I've been thinking of adding for a while (in my backlog, ofc), but I also happened to see https://github.com/lukechilds/merge-images#nodejs-usage today, which is another interesting workaround for Node usage.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.