agent-substrate / agent-substrate/substrate

Create a pattern for reporting fine-grained error details in a machine-readable way

Ouverte
#45 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
area/api area/tests kind/feature prio/P1
Langage dominant
Go
Étoiles
1.8k
Forks
316
Merge moyen
2 j 43 min
PR mergées (30 j)
287

Description

Currently, we are testing the error message strings emitted from ate-api-server in functional_test.go. This is pretty fraught, since those messages aren't necessarily going to be stable as code is refactored.

Instead, we should use the [Status.Details field](https://pkg.go.dev/google.golang.org/grpc/status#FromProto) with an ate-specific details proto. We can define a fine-grained code for each logical error, in case clients need to distinguish situations beyond just the canonical code.

For example,
* If we can't find a free worker, we might return a status error where code=RESOURCE_EXHAUSTED, and details has an ateapipb.ErrorDetails proto with fine_grained_code=NO_FREE_WORKERS

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.