agent-substrate / agent-substrate/substrate

atenet-router traces are detached + do not use ate.* attribute keys

Open
#427 1 comment 0 reactions 1 assignee Claimed by @krisztianfekete View on GitHub
area/observability kind/bug
Dominant language
Go
Stars
1.8k
Forks
316
Avg merge
2d 43m
Merged PRs (30d)
287

Description

## Expected Behavior

One `ResumeActor` request should show up as a single connected trace across atenet-router -> ateapi -> atelet -> ateom, and the router spans should have the same `ate.*` attributes we standardized in #412.

## Actual Behavior

You get two separate traces for the same request: one for the ateapi -> atelet -> ateom path, and a detached one with just the atenet-router spans (see @zoez7's screenshots on #412). The trace context seemingly doesn't survive the router hop.

Additionally, the router spans use non-namespaced keys instead of the `ate.*` convention, e.g. `atespace`, `actor_id`, `actor_template_namespace`, `actor_template_name`, and `outcome`

## Steps to Reproduce the Problem

1. Run the setup scripts
2. Run ` kubectl ate resume actor my-counter-1 -a demo --trace`
3. Open Jaeger/similar, check the traces

## Specifications

- Version: main
- Platform: all

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.