agent-substrate / agent-substrate/substrate

Expand validation test coverage at atelet's RPC layer

オープン
#217 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
area/tests kind/feature
主要言語
Go
スター
1.8k
フォーク
316
平均マージ
2日 43分
マージ済み PR(30日)
287

説明

Follow-up from review discussion on #206 (https://github.com/agent-substrate/substrate/pull/206#discussion_r3385245614).

#206 (in review) validates path-construction inputs at atelet's RPC boundary. The negative path is tested through the public surface (`TestRPCBoundariesReject` calls the real `Run`/`Checkpoint`/`Restore` handlers and asserts `InvalidArgument`), but the positive path cannot be asserted through the RPCs: after validation passes, the handlers immediately need object storage, the actor dirs under `/var/lib/ateom-gvisor` (`ateompath.BasePath` is a const), image pulls, and a live ateom.

Making the happy path testable means making those dependencies fakeable (injectable storage and dialer, a redirectable base path). That refactor is the bulk of this issue; the additional tests follow from it. It would also be a good foundation for unit testing the checkpoint/restore flows generally, which today are only covered by e2e.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。