agent-substrate / agent-substrate/substrate

Expand validation test coverage at atelet's RPC layer

Open
#217 1 comment 0 reactions 0 assignees View on GitHub
area/tests kind/feature
Dominant language
Go
Stars
1.8k
Forks
316
Avg merge
2d 43m
Merged PRs (30d)
287

Description

Follow-up from review discussion on #206 (https://github.com/agent-substrate/substrate/pull/206#discussion_r3385245614).

#206 (in review) validates path-construction inputs at atelet's RPC boundary. The negative path is tested through the public surface (`TestRPCBoundariesReject` calls the real `Run`/`Checkpoint`/`Restore` handlers and asserts `InvalidArgument`), but the positive path cannot be asserted through the RPCs: after validation passes, the handlers immediately need object storage, the actor dirs under `/var/lib/ateom-gvisor` (`ateompath.BasePath` is a const), image pulls, and a live ateom.

Making the happy path testable means making those dependencies fakeable (injectable storage and dialer, a redirectable base path). That refactor is the bulk of this issue; the additional tests follow from it. It would also be a good foundation for unit testing the checkpoint/restore flows generally, which today are only covered by e2e.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.