agent-substrate / agent-substrate/substrate

Unify resources.ValidateActorID with the ValidateActorRef rules from #206

Đang mở
#216 1 bình luận 0 reaction 0 người được giao Xem trên GitHub
area/api-machinery kind/cleanup
Ngôn ngữ chính
Go
Star
1.8k
Fork
316
Merge trung bình
2 ngày 43 phút
Pull request đã merge (30 ngày)
287

Mô tả

#206 (in review) adds DNS-1123 validators to `internal/resources` using k8s.io/apimachinery, including `ValidateActorRef`, which checks actor IDs with the same DNS-1123 label rule that the existing `ValidateActorID` implements with a hand-rolled regex. Once #206 merges, the package will contain two implementations of one rule, which can drift.

Unify them on a single implementation. This was deliberately kept out of #206 because it changes ate-api-server's client-facing error responses: `ValidateActorID` returns hand-written rule prose, while the apimachinery validators return generated messages, so the consolidation needs a decision about which error text API clients see.

While here, consider applying the other #206 validators (`ValidateActorRef`, `ValidateRunscHash`, `ValidateSnapshotURIPrefix`) at the API server and controller boundaries. Every one of these values originates in user-supplied API/CRD data, so bad values can be rejected at admission time instead of at actor-activation time deep in atelet.

Blocked on #206 merging.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.