agent-substrate / agent-substrate/substrate

TestActorSnapshotLifecycle reads only the first page of ListActorSnapshots

Đang mở
#1,126 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
area/storage area/tests kind/bug
Ngôn ngữ chính
Go
Star
1.8k
Fork
316
Merge trung bình
2 ngày 43 phút
Pull request đã merge (30 ngày)
287

Mô tả

`TestActorSnapshotLifecycle` fails with `snapshot %q missing from ListActorSnapshots` on a cluster that has been up a while.

The snapshot is there. `GetActorSnapshot` succeeds on it one line earlier. The test then calls `ListActorSnapshots` once and treats the first page as the whole list, but the list is name-ordered and the API says there is more in `NextPageToken`. On the cluster where this reproduced, the newly created snapshot sorted 1408th of 1518 against a page size of 1000 — page two.

`createActor` reads `ListActors` the same way.

CI never sees it: every run gets a fresh cluster, and the `demo` atespace stays far below one page. It bites long-lived and shared clusters, and it cost time during the #1050 investigation by looking like a real snapshot loss.

Measured on the cluster where it reproduced: 15/35 runs failed before, 0/35 after following the page tokens (Fisher one-sided p = 4.5e-6).

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.