agent-substrate / agent-substrate/substrate

Move PostgreSQL expired-lease cleanup off the lock acquisition path

Aperta
#1,040 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
area/api-machinery kind/cleanup
Lingua principale
Go
Stelle
1.8k
Fork
316
Merge medio
2g 43m
PR unite (30g)
287

Descrizione

## Problem

In #1023 `atepg.AcquireLock` currently runs `DELETE FROM leases WHERE expires_at <= clock_timestamp()` before every lease acquisition. The `expires_at` index keeps this bounded, but it still adds an extra database write and round trip to every lock acquisition, including when there are no expired leases.

The acquisition query already reclaims an expired lease for the requested key through `INSERT ... ON CONFLICT ... DO UPDATE ... WHERE leases.expires_at <= clock_timestamp()`, so global cleanup is not required for lock correctness. It only prevents expired rows for inactive keys from accumulating.

## Proposed follow-up

Move global expired-lease cleanup off the acquisition path, for example to a periodic background task with a bounded interval and/or batch size. In a multi-replica deployment, ensure cleanup work is not needlessly duplicated or that concurrent cleaners remain cheap and safe.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.