agent-substrate / agent-substrate/substrate

e2e: nothing catches actor metric continuity across suspend/resume

Đang mở
#1,036 0 bình luận 0 reaction 1 người được giao Được @git286 nhận Xem trên GitHub
area/dev-infra area/observability kind/feature
Ngôn ngữ chính
Go
Star
1.8k
Fork
316
Merge trung bình
2 ngày 43 phút
Pull request đã merge (30 ngày)
287

Mô tả

#761 reported that an actor's own counters merge and inflate across a suspend/resume, silently.
Everything in `internal/e2e` is platform plane, where we own the emitter, and we don't have coverage for workload emitted telemetry today.

So I'd like a small test where an actor increments a counter, we suspend and resume it, and we assert the total afterwards is a sum of what the actor actually counted rather than a reset artifact.

It would be nice to have this while we are designing #853 as

* behaviour-wise this is what we want, regardless of the final relay design
* it can help validating our relay design

Note: this will fail today, but that's the point. We probably want to mark it as optional until the relay lands, what do you all think?

High level idea:

* a tiny actor that counts something and exports otlp. The demo in #750 may already give us this, and I'd rather not build a second one
* assert on the delta across the lifecycle operation, not on an absolute value

cc @git286 @JeffLuoo @sanskar-singh-2403 @maxsmythe

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.