agateblue / agateblue/django-dynamic-preferences

FloatPreference should be able to be initialized from both floats and ints

Aperta
#265 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Python
Stelle
359
Fork
86
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Recently I met a problem with setting a `FloatPrefeerence` to an int value instead of its float equivalent (`1` instead of `1.0`), which sounds reasonable, but I got this error:

```
File "/app/.venv/lib/python3.10/site-packages/dynamic_preferences/models.py", line 53, in set_value
self.raw_value = self.preference.serializer.serialize(value)
File "/app/.venv/lib/python3.10/site-packages/dynamic_preferences/serializers.py", line 39, in serialize
return cls.to_db(value, **kwargs)
File "/app/.venv/lib/python3.10/site-packages/dynamic_preferences/serializers.py", line 54, in to_db
return text_type(cls.clean_to_db_value(value))
File "/app/.venv/lib/python3.10/site-packages/dynamic_preferences/serializers.py", line 163, in clean_to_db_value
raise cls.exception('FloatSerializer can only serialize Float instances')
```

`FloatSerializer` should INMHO accept ints as well, for more flexibility in user input

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.