Rename the TX `resampling_active` diagnostics key now that its value changed meaning
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- cpp
- Domain
- audio-video-rtc, desktop, observability
Research direction
Start at AudioEngine::audioEndpointDiagnostics() and txAudioResamplingRoute(), then read docs/architecture/audio-pipeline.md and the review context in PR #4875. Resolve whether the legacy key is renamed or retired, coordinate with support-bundle parsers, and verify diagnostics consumers use the new meaning without an ambiguous cross-version diff.
Written by the indexing model from the issue text.
Description
Follow-up from PR #4875 (48 kHz TX voice refactor). Raised by @jensenpat in review; we merged without doing it and committed in the review dismissal to doing it if still wanted, so this issue exists to make that commitment visible rather than lost.
The problem
AudioEngine::audioEndpointDiagnostics() emits resampling_active under the same JSON key it has always used, but the value it reports changed with #4875:
| Mic capture rate | Before #4875 | After #4875 |
|---|---|---|
| 48 kHz | true |
true |
| 24 kHz | false |
true |
Before, the key meant "the TX path resamples the capture rate to 24 kHz" (m_txNeedsResample = rate != 24000). Now the normal voice route always performs a 48 → 24 kHz egress SRC, so txAudioResamplingRoute() returns active = true unconditionally for voice.
The new value is correct — the SRC genuinely runs — and the behaviour is documented under "TX rate diagnostics" in docs/architecture/audio-pipeline.md. #4875 also added three unambiguous sibling keys (voice_input_normalizing_to_48k, voice_egress_resampling_to_24k, rade_resampling_to_24k).
The residual concern is real regardless: a support-bundle diff across versions will show the value flip under an unchanged key, and anyone comparing bundles from before and after #4875 can misread it as a behaviour regression on 24 kHz mics. DeviceDiagnostics renamed its sibling key for exactly this reason; this one did not.
Suggested fix
Rename to something that states the new meaning (e.g. tx_route_resampling_active), or retire it in favour of the three explicit siblings that now carry the detail.
Either way, coordinate with whatever parses support bundles.
Original review thread: https://github.com/aethersdr/AetherSDR/pull/4875
- Dominant language
- C++
- Stars
- 221
- Forks
- 117
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 299
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aethersdr/AetherSDR
-
audio documentation good first issue maintainer-review
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
bug CW maintainer-review safety
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
docs(agents): family PRs must stay in the family tree (shared applet/pan/model edits stall review) Opendocumentation enhancement maintainer-review
Difficulty 1/5 1-3 hours Newbie friendliness 90/100
-
bug good first issue GUI maintainer-review priority: low
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
bug
Difficulty 1/5 Under an hour Newbie friendliness 86/100
All issues in aethersdr/AetherSDR
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·