aeharding / aeharding/wingover

boot: a WAL read that never settles leaves a permanently blank app

Aperta
#194 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
TypeScript
Stelle
0
Fork
0
Merge medio
4h 2m
PR unite (30g)
6

Descrizione

Pre-existing (from #162), found during an adversarial review of #189.

If `readWal()` never settles, `hydrationState` stays `"pending"` and `AppBody`
renders `null` forever. `BootFailedScreen` is only reached on **rejection**, so
a hang has no reload affordance at all: the pilot gets a black screen and no way
out.

Reproduced by accident with a bad patch while testing the boot gate under a
stalled IndexedDB transaction.

Safe from the data-loss angle — nothing can clear the WAL in that state, so the
flight survives — but it is indistinguishable to a pilot from the black screen
of #185, and the recovery (force-quit) is the one thing that looks most like
data loss even when it is not.

Worth pairing with #188: the boot gate is upstream of any React error boundary,
so the boundary cannot cover this. A timeout that falls through to
`BootFailedScreen` would.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.