aeharding / aeharding/voyager

Tapping on an uploaded picture in the post editor should bring up a larger preview

Aperta
#1,097 1 commento 2 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
TypeScript
Stelle
1.8k
Fork
174
Metriche di merge delle PR
Metriche PR in attesa

Descrizione

**Is your feature request related to a problem? Please describe.**
After uploading a picture in the post editor, Voyager only shows a tiny preview. Understandable, because a larger version might obscure the inputs below, but also annoying if you're struggling with writing a good title and want to avoid writing the same text that's already in the meme.

![image](https://github.com/aeharding/voyager/assets/98132670/b6c2712a-2840-42d1-bc62-caa1679eed5e)

**Describe the solution you'd like**
When tapping the preview image in the post editor, a lightbox view should pop up showing a full size preview. Basically like the one that's available when viewing a regular post, sans the voting and share buttons at the bottom.

**Describe alternatives you've considered**
Open the photos app, find the picture there, and then switch back to Voyager, I guess. Doable but annoying, especially if you have a LOT of pictures.

**Additional context**
I tried implementing this myself by using the existing `GalleryImg` component in `PhotoPreview`, but even after moving the `GalleryProvider` outside of the `PageContext` I can't get it to work. The lightbox always comes up empty and worse yet, the close button doesn't even work. Not sure what I'm missing, but with the right clue I might be able to finish this myself.

Best I can currently do is probably just removing the size restriction so tapping on the preview would show a larger version *inside* the post editor, not in a lightbox.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.