adopted-ember-addons / adopted-ember-addons/validated-changeset

newValue received in validation for moment property is plain object instead of moment instance

Ouverte
#193 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
TypeScript
Étoiles
38
Forks
27
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

I'm using `ember-changeset` v4.1.2 (`validated-changeset` v1.3.4) and have an ES6 class with a tracked property whose value is either `null` or a `moment` instance. If that property on an instance of the class is set to a `moment` instance and I create a Changeset around the object, when I call the object's `.validate()` method the value passed into the validator as the `newValue` is a plain object with the properties of the `moment` instance copied onto it. The validator checks the value's `.isValid()` method, which is part of the `moment` object but is not present on the `newValue` received by the validator. The issue seems to be caused by the [`unwrap` method](https://github.com/validated-changeset/validated-changeset/blob/c1c95b729aae80fd30b30b691202a94c974a3309/src/utils/object-tree-node.ts#L106) creating a plain object instead of returning the original class.

Repro:

```js
import moment from 'moment';

class FormData {
date = moment();
}

const formData = new FormData();
const validator = ({ newValue }) => {
return moment.isMoment(newValue) && newValue.isValid();
};
const changeset = Changeset(formData, validator);

changeset.validate('date'); // results in `TypeError: newValue.isValid is not a function` being thrown.
```

Perhaps I'm thinking about this in the wrong way, but it seems reasonable to expect that the `newValue` provided to a validator has the same signature as the underlying value, otherwise validator functions lose access to methods that were present on the original data type that are often useful as part of the validation routine.

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.