adopted-ember-addons / adopted-ember-addons/validated-changeset
getters/setters are executed against the original model, not the modified one
- Langage dominant
- TypeScript
- Étoiles
- 38
- Forks
- 27
- Métriques de merge des PR
- Aucune PR mergée en 30 j
Description
Consider the following class:
```ts
class A {
foo = 1;
get bar(): number {
return 2 * this.foo;
}
set bar(value: number) {
this.foo = value / 2;
}
}
```
If you create a change buffer over an instance of this class and modify it:
```ts
changebuffer.set('foo', 2);
console.log(changebuffer.get('bar')); // 2, but I'd expect 4
changebuffer.set('bar', 6);
console.log(changebuffer.get('foo')); // 1, but I'd expect 3
```
the results are a bit unexpected. Would you consider getting the property descriptor
```ts
const descriptor = Object.getOwnPropertyDescriptor(Object.getPrototypeOf(target), prop);
```
and then executing it against the change buffer instance?
Guide de contribution
Aucun guide de contribution indexé pour ce dépôt
Évaluation
Cette issue n'a pas encore été évaluée.