adopted-ember-addons / adopted-ember-addons/emberx-select

Problem with contextual components

未关闭
#221 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
triage
主要语言
JavaScript
星标
198
派生
77
PR 合并指标
30 天内没有已合并 PR

描述

ember-cli: 3.4.1
node: 10.10.0
os: linux x64

on starting the ember application, I get this error message:
_Cannot read property 'indexOf' of undefined_
Stack Trace and Error Report: /tmp/error.dump.788cf782093e6537f56a264725f71192.log

seems to be an issue with emberx-select-blockless in API addon.
Meanwhile, I understand that the emberx-select-blockless is deprecated, I was able to get it working in ember-cli@3.4.0-beta.2

```
hasContextualComponents: function () {
var VersionChecker = require('ember-cli-version-checker');

var checker = new VersionChecker(this);
var dep = checker.for('ember', 'bower');

var isBetaOrCanary = ['beta', 'canary'].filter(function(version) {
return dep.version.indexOf(version) >= 0; //dep.version is undefined.
});

return !!(dep.satisfies('>= 2.3.0 < 3.0.0') || isBetaOrCanary.length > 0);
},
```
works fine in: ember-cli@3.4.0-beta.2
broken in: ember-cli@3.4.1

With trace:
- broccoliBuilderErrorStack: [undefined]
- codeFrame: [undefined]
- errorMessage: Cannot read property 'indexOf' of undefined
- errorType: [undefined]
- location:
- column: [undefined]
- file: [undefined]
- line: [undefined]
- message: Cannot read property 'indexOf' of undefined
- name: TypeError
- nodeAnnotation: [undefined]
- nodeName: [undefined]
- originalErrorMessage: [undefined]
- stack: TypeError: Cannot read property 'indexOf' of undefined
at /home/monkey/projects/p30m/phmscli/appkit/node_modules/emberx-select-blockless/node_modules/emberx-select/index.js:14:26
at Array.filter ()
at Class.hasContextualComponents (/home/monkey/projects/p30m/phmscli/appkit/node_modules/emberx-select-blockless/node_modules/emberx-select/index.js:13:45)
at Class.treeForAddonTemplates (/home/monkey/projects/p30m/phmscli/appkit/node_modules/emberx-select-blockless/node_modules/emberx-select/index.js:24:14)
at Class._treeFor (/home/monkey/projects/p30m/phmscli/appkit/node_modules/ember-cli/lib/models/addon.js:617:33)
at Class._addonTemplateFiles (/home/monkey/projects/p30m/phmscli/appkit/node_modules/ember-cli/lib/models/addon.js:1090:31)
at Class.compileTemplates (/home/monkey/projects/p30m/phmscli/appkit/node_modules/ember-cli/lib/models/addon.js:1141:81)
at Class.compileAddon (/home/monkey/projects/p30m/phmscli/appkit/node_modules/ember-cli/lib/models/addon.js:1205:30)
at Class.treeForAddon (/home/monkey/projects/p30m/phmscli/appkit/node_modules/ember-cli/lib/models/addon.js:860:26)
at Class._treeFor (/home/monkey/projects/p30m/phmscli/appkit/node_modules/ember-cli/lib/models/addon.js:617:33)

Any suggestions, help is appreciated

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start with node_modules/emberx-select-blockless/node_modules/emberx-select/index.js, especially hasContextualComponents and its ember-cli-version-checker usage. Reproduce the startup failure with ember-cli 3.4.1 and compare it with 3.4.0-beta.2; done means the application starts without the reported TypeError.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, node.js
领域
frontend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。